chore(suite): add @typescript-eslint/strict-boolean-expressions rule as warning #10757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
force-pushed
the
add-strict-boolean-expressions
branch
3 times, most recently
from
d88e753
to
7368b2a
Compare
peter-sanderson
requested review from
szymonlesisz,
karliatto,
mroz22 and
marekrjpolak
as code owners
peter-sanderson
commented
Jan 23, 2024
.eslintrc.js
Outdated
| @@ -11,6 +11,8 @@ module.exports = { | |||
| ecmaFeatures: { | |||
| jsx: true, | |||
| }, | |||
| project: ["./tsconfig.json"], | |||
There was a problem hiding this comment.
This is required to have for @typescript-eslint/strict-boolean-expressions rule to work
peter-sanderson
commented
Jan 23, 2024
| @@ -0,0 +1,5 @@ | |||
| module.exports = { | |||
| parserOptions: { | |||
| tsconfigRootDir: __dirname, | |||
There was a problem hiding this comment.
Every package needs to have this ti make sure the eslint uses the local tsconfig and not the global one as most of packages has some custom configurations.
peter-sanderson
commented
Jan 23, 2024
| @@ -1,3 +1,4 @@ | |||
| // eslint-disable-next-line @typescript-eslint/no-shadow | |||
There was a problem hiding this comment.
I think those errors poped up when ESLint got the type-information from typescript. But not sure.
There was a problem hiding this comment.
Seems to be somehow globally imported from typescript/lib/lib.dom.d.ts
peter-sanderson
force-pushed
the
add-strict-boolean-expressions
branch
from
7368b2a
to
b7ff1c7
Compare
peter-sanderson
force-pushed
the
add-strict-boolean-expressions
branch
2 times, most recently
from
4c888a6
to
d5c2f3c
Compare
|
peter-sanderson
force-pushed
the
add-strict-boolean-expressions
branch
from
d5c2f3c
to
0e38f52
Compare
peter-sanderson
force-pushed
the
add-strict-boolean-expressions
branch
2 times, most recently
from
5fd4d23
to
c93d308
Compare
peter-sanderson
force-pushed
the
add-strict-boolean-expressions
branch
5 times, most recently
from
b13e2d3
to
0735de8
Compare
peter-sanderson
force-pushed
the
add-strict-boolean-expressions
branch
from
0735de8
to
6abf320
Compare
peter-sanderson
force-pushed
the
add-strict-boolean-expressions
branch
from
6abf320
to
be0701c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn nx:lint:js